Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable trailing comma #1583

Merged
merged 4 commits into from Aug 17, 2022

Conversation

paul-dingemans
Copy link
Collaborator

Description

Enable trailing comma on declaration and call site.

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

@shashachu
Copy link
Contributor

Just to confirm: this not only allows but enforces a trailing comma?

@paul-dingemans
Copy link
Collaborator Author

Just to confirm: this not only allows but enforces a trailing comma?

Yes indeed. The codebase just feel way more consistent when the trailing comma is used always or never. This prevents discussions about usage of a trailing comma at specific location. But it is possible to set trailing comma's for call site and declaration site independently (also see separate commits).

The build is probably broken because other changes have been merged before this one and the trailing comma is not yet applied consistently in those changes.

@paul-dingemans paul-dingemans added this to the 0.47.0 milestone Aug 16, 2022
@paul-dingemans paul-dingemans merged commit 1d9ca64 into pinterest:master Aug 17, 2022
@paul-dingemans paul-dingemans deleted the enable-trailing-comma branch August 17, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants