Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate action runs for eg. Dependabot #1220

Merged
merged 1 commit into from Nov 15, 2021
Merged

Avoid duplicate action runs for eg. Dependabot #1220

merged 1 commit into from Nov 15, 2021

Conversation

voxpelli
Copy link
Contributor

Dependabot, and some of you who are maintainers here, pushes to branches in the pino repo itself and unless one tell GitHub Action that it should jobs to only trigger the push events on the main branch, then it will trigger both the push and the pull_request events when PR:s gets opened for those, making a Dependabot PR look like:

Ska虉rmavbild 2021-11-15 kl  23 02 06

I recently made this change myself to get rid of this duplicates, thought I would share 馃憤

As it pushes to a branch in the pino repo itself, unless we tell the CI jobs to only trigger `push` on the `main` branch, then it will trigger both `push` and `pull_request` on eg. the Dependabot PR:s
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

26fc85fe50f1e9bb0f0252283e9a99ca

@jsumners jsumners merged commit d28197f into pinojs:master Nov 15, 2021
@voxpelli voxpelli deleted the make-actions-target-branch branch November 15, 2021 22:26
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants