Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that watchFileCreated fails are timeouts #1219

Merged
merged 1 commit into from Nov 15, 2021
Merged

Clarify that watchFileCreated fails are timeouts #1219

merged 1 commit into from Nov 15, 2021

Conversation

voxpelli
Copy link
Contributor

Relates to #1215, where it looks like the error is that a file isn't created, but it can just as well (and more likely) be that the file watch times out.

This change avoids such confusion going forward.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@voxpelli voxpelli mentioned this pull request Nov 15, 2021
@mcollina mcollina merged commit 8fde791 into pinojs:master Nov 15, 2021
@voxpelli voxpelli deleted the clarify-file-creation-watch-error branch November 15, 2021 21:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants