Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify options.timestamp usage #953

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Conversation

cmawhorter
Copy link
Contributor

I mistook the meaning of ,"timestamp"... and description and was wondering why my log entries looked like this: {"level":302021-01-16T22:08:04.469Z,"pid":11224, ....

the way this works was a little surprising but i'm sure makes sense for perf reasons.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Yes, it's for perf reason as it is one of the most sensitive areas of the code.

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants