-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme mixin doc: wrong sample code #951
Labels
Comments
Interesting. That snippet made sense as merged in that PR, but has since been edited to lose its intended meaning. |
I think we made a mistake in #928. Would you like to send a PR to fix? |
hraban
added a commit
to hraban/pino
that referenced
this issue
Jan 15, 2021
Restores the original semantics introduced by afb639c (pinojs#857). Reverts the changes to this documentation from 6e50d72 (pinojs#928) and 6c42f14 (pinojs#926). Fixes pinojs#951.
Merged
PR: #952 |
This was referenced Mar 15, 2021
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The section on mixins in the readme has the following code:
but (after fixing the last two
pino
references tologger
), the prophecy in the logs doesn't actually come to be.What was this bit of code intended to illustrate?
https://github.com/pinojs/pino/blob/master/docs/api.md#mixin-function
The text was updated successfully, but these errors were encountered: