Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing var with let/const, somewhere left var because scope, somew… #950

Merged
merged 7 commits into from
Jan 16, 2021
Merged

Replacing var with let/const, somewhere left var because scope, somew… #950

merged 7 commits into from
Jan 16, 2021

Conversation

salesh
Copy link
Contributor

@salesh salesh commented Jan 13, 2021

#947
Replacing var with let/const, somewhere left var because scope somewhere left var because "for" + resolved all standard issues

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Benchmarks seems ok.

benchmarks/utils/runbench.js Outdated Show resolved Hide resolved
browser.js Show resolved Hide resolved
lib/levels.js Outdated Show resolved Hide resolved
pino.js Outdated Show resolved Hide resolved
eslintrc.json Outdated Show resolved Hide resolved
eslintrc.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants