integrate fast-redact v3 #917
Conversation
Can you please this? I don't understand the change. |
| } else { | ||
| const wrappedCensor = typeof censor === 'function' ? (value, path) => { | ||
| return censor(value, [k, ...path]) | ||
| } : censor |
There was a problem hiding this comment.
Why is this needed? I would prefer if we avoid this.
There was a problem hiding this comment.
Answering for this and also quoted comment
Can you please this? I don't understand the change.
This PR davidmarkclements/fast-redact#16 added the functionality to pass a path array to the censor function.
We had to do this because otherwise the path array is missing the top level key.
For instance, say we have a logger set up like so:
const pino = require('.')
const logger = pino({redact: {paths: ['a.b.c'], censor: console.log }})
logger.info({a: {b: {c: 'redact me'}}})this will log out: redact me ['a', 'b', 'c']
without this change this will log out: redact me ['b', 'c']
This is because, fast-redact is being used per key on the logged object, so it is passed a redaction path of 'b.c' and then works on the object {b: {c: 'redact me'}} instead of 'a.b.c', working on the object {a: {b: {c: 'redact me'}}}.
AlexNiallMalin
force-pushed
the
fast-redact-v3
branch
from
bc587c0
to
f498f68
Compare
|
I'm not clear. Is this changing the current user API for Pino? |
@jsumners - No breaking changes to the API but the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
pathargument incensorfunctionlib/redaction.jsso that thepathargument contains top level key e.g. given a pathreq.headers.cookiereqwould not be part ofpathwithout these changes e.g.['headers', 'cookie']instead of['req', 'headers', 'cookie']Benchmark for master
Benchmark for this branch