Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Document Redact Path as Case Sensitive #915

Closed
shellscape opened this issue Oct 2, 2020 · 5 comments
Closed

Please Document Redact Path as Case Sensitive #915

shellscape opened this issue Oct 2, 2020 · 5 comments

Comments

@shellscape
Copy link

While there are wider issues with fast-redact davidmarkclements/fast-redact#28, I believe it would be advantageous to the userbase of pino to document clearly and boldly that redact paths are case-sensitive, perhaps on this document https://github.com/pinojs/pino/blob/master/docs/redaction.md.

@mcollina
Copy link
Member

mcollina commented Oct 2, 2020

Sure, would you like to send a PR?

@shellscape
Copy link
Author

I've done my duty by reporting it, I think you all can handle a docs addition and will know best where to put it. (When I can find the time between babies to contribute, I'm pretty caught up maintaining the Rollup plugins repo and a host of other projects I maintain. I get the why for asking, but I tend not to ask that from prolific oss contributors assuming that if they had the time, they'd have already opened one)

I'll be asking from work later today if I can be granted the time to contribute a fix for case insensitivity for davidmarkclements/fast-redact#28.

@mcollina
Copy link
Member

mcollina commented Oct 2, 2020

That would truly be fantastic.

@davidmarkclements
Copy link
Member

closed by #915

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants