"timestamp" option is ignored in Browser environment

[acro5piano]

Hi, thank you for the great library.

I've run the following code.

I expected time should become ISO String, but actually the output is still epochTime.

import pino from 'pino'

const logger = pino({
  timestamp: () => `,"time":"${new Date(Date.now()).toISOString()}"`,
  browser: {
    asObject: true,
  },
})

logger.info('Running app')

is this intensional? Thanks in advance.

[mcollina]

Yes, this is intentional. In the browser some of the internals are different :( and we cannot have the same features. We might want to add something analog to this. Would you like to send a PR?

[acro5piano]

@mcollina

Thanks for the reply. The code is located here, right? I'll try to work on it :)

https://github.com/pinojs/pino/blob/master/browser.js#L211

And it looks like passing opts.timestamp to wrap will add customization capability.

https://github.com/pinojs/pino/blob/master/browser.js#L177

[mcollina]

Yes

[dariolongo]

Hi,
First of all, thanks for Pino!

Hope this can help others...

Using the timestamp function and browser.asObject true:

timestamp: () => `,"time":"${new Date(Date.now()).toISOString()}"`,
browser: {
  asObject: true
}

it's ok on stdout:

{"level":30,"time":"2021-11-03T10:59:59.348Z","msg":"Running app"}

but it's not totally correct in the browser:

Using this:

timestamp: pino.stdTimeFunctions.isoTime,

work well for both!

Bey

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.