Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle formatting a Symbol #717

Merged
merged 1 commit into from Oct 1, 2019
Merged

Conversation

Zirak
Copy link
Contributor

@Zirak Zirak commented Oct 1, 2019

Bump up the minimum quick-format-unescaped version, and test passing a
Symbol as a format argument.

Fix #715.

Bump up the minimum `quick-format-unescaped` version, and test passing a
Symbol as a format argument.

Fix pinojs#715.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidmarkclements davidmarkclements merged commit a9ca301 into pinojs:master Oct 1, 2019
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
@Zirak Zirak deleted the symbol-support branch February 21, 2022 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging a symbol throws a TypeError
3 participants