test: make test timeouts configurable #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
Shouldn't this be documented somewhere? |
mcollina
reviewed
Nov 23, 2021
jsumners
approved these changes
Nov 23, 2021
|
I'm not sure we should document this.. but if we want to |
How would people know it's there without randomly stumbling upon it in code then? |
|
A timeout error would point to that block of code. |
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
|
@mcollina thanks, accepted your suggestions. From the output I'll confirm it was pretty easy to see that the failures were a timeout issue and where the timeouts where. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw some timeouts in the tests when we were running to validate in Red Hat containers (for example: https://catalog.redhat.com/software/containers/ubi8/nodejs-12/5d3fff015a13461f5fb8635a).
Our investigation so far points to it being loading/resource issue on the machines we are running versus anything in the tests.
We'd like to be able to extended timeouts in the tests, this PR adds a simple way to do that through the environment.