New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make transport Jest-aware #1181
Conversation
I’ll try it with this PR, see if my CI still fails |
Beautiful, works perfectly (both locally and on CI)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't want to approve this. It seems more like a bug in another package to me. But I'm not blocking it.
I'm with you, but I do not see any other way to fix it. It's a massive design flaw in Jest and part of the enormous technical debt they push on the rest of the ecosystem. I do not feel we should spend energy to make a stand against jest. My twitter rants about it are enough. Let's land this and move on :(. |
@jsumners I've found a better fix for this. |
@mcollina oh cool, so my suggestion DID work! |
struck out below was written with the old solution in mind, should have checked the new one first. Since it it isn't specific to Jest it's an acceptable workaround for us. However, as a general rule, the points below still stand.
|
I argue it is still specific to Jest. We have to keep the comment in the code explaining why the import is being done the way it is specifically because of Jest. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #1179