Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a deprecation warning for pino.final() in Node v14+ #1175

Closed
mcollina opened this issue Oct 20, 2021 · 3 comments · Fixed by #1199
Closed

Add a deprecation warning for pino.final() in Node v14+ #1175

mcollina opened this issue Oct 20, 2021 · 3 comments · Fixed by #1199
Labels
good first issue

Comments

@mcollina
Copy link
Member

Correct! How about we emit the warning if on Node v14+?

Seems acceptable.

Originally posted by @jsumners in #1171 (comment)
@davidmarkclements
Copy link
Member

shouldn't we also warn 12 users, maybe with a different message?

@mcollina
Copy link
Member Author

Node 12 users are in more trouble anyway "start migrating now" would be the best message.

@sameer-coder sameer-coder mentioned this issue Oct 29, 2021
Merged
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecation warning for pino.final() in Node v14+ sameer-coder/pino
3 participants
@mcollina @jsumners @davidmarkclements