Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line simplification for development #366

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

mcollina
Copy link
Member

We say that pino-pretty is a development tool, however it's very verbose in its default settings to use for local development. In this PR I simplified it a bit:

  1. Use the local timezone and just print the time. If I'm developing code I want to reason on my own timezone and I'm not interested in what day it is.
  2. remove the hostname as it's unlikely to change given that's my development machine.

This was inspired by fastify/fastify-cli#536

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2831970454

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2831615331: 0.0%
Covered Lines: 383
Relevant Lines: 383

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 10, 2022

Pull Request Test Coverage Report for Build 2832449335

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2831615331: 0.0%
Covered Lines: 383
Relevant Lines: 383

💛 - Coveralls

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

test/basic.test.js Outdated Show resolved Hide resolved
mcollina and others added 2 commits August 10, 2022 13:58
Co-authored-by: James Sumners <james@sumners.email>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants