Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing delimiter in default path #1

Open
dirk-ecker opened this issue Jan 27, 2021 · 3 comments
Open

Missing delimiter in default path #1

dirk-ecker opened this issue Jan 27, 2021 · 3 comments

Comments

@dirk-ecker
Copy link

const defaultOptions = {
path: os.tmpdir() + 'aborsculpt.json',
interval: 60000,
loggers: []

path gets '/tmpaborsculpt.json' and I think you want '/tmp/aborsculpt.json'

@mcollina
Copy link
Member

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

@dirk-ecker
Copy link
Author

For this to test I have to get access to the internals of the constructor. This seems not possible without rewriting the tool, or am I wrong. Or do you suggest to check for the existence of the file in the temp directory?

@jsumners
Copy link
Member

The tests already look for files in /tmp. I am certain there is a lot of room for improvement in them, but following the current pattern should be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants