Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pino-pretty as a dev dependency #152

Merged
merged 1 commit into from Dec 13, 2021
Merged

Move pino-pretty as a dev dependency #152

merged 1 commit into from Dec 13, 2021

Conversation

jonathansamines
Copy link
Contributor

pino-pretty seems to be only useful as part of the benchmarking code, so moving to dev dependencies instead.

mcollina
mcollina approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.976% when pulling b99e37c on jonathansamines:feature/remove-pino-pretty into 204c96e on pinojs:master.

@mcollina mcollina merged commit 8806bb5 into hapijs:master Dec 13, 2021
@jonathansamines jonathansamines deleted the feature/remove-pino-pretty branch January 31, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lauraseidler lauraseidler lauraseidler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonathansamines @coveralls @mcollina @lauraseidler