New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read ECONRESET error #145 #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a unit test?
There is a conflict, could you rebase? |
tests are failing, could you take a look? |
Not really and sorry for the breakage. Would you like to help maintaining this module? I don't have time and/or context as it has been long before I used Hapi in production. |
Feel free to bring those changes back it if you want to. |
Hi @jonathansamines ! With the config in this pr description. Our server give us a very, very good performance results. Could we share more details at this pr in order to find the correct config needed for production? See here an example of our config.. https://github.com/aaestrada/pino-tranport/blob/master/pino-file/index.js We ran some sintetic tests with blazemeter in production we have: I'll happy to collaborate with you to find the best solution here... |
I don't understand @aaestrada. I'll be happy to review a PR. |
Hey @mcollina. I just created #153 to restore support for tags in
Sure, what kind of help are you looking for? |
Hi @ovhemert! Thanks for this information! at issue #145 This will be so helpful for us! So i maked this pr with these changes?
Replace the
event.error
condition herewith
so after this change should be able to ignore this events tags as you are showing here... right?