Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3-[4.0-bug-hunting]-[Tiup]-Download progress shows p/s #451

Closed
sre-bot opened this issue Jun 5, 2020 · 1 comment · Fixed by #1312
Closed

P3-[4.0-bug-hunting]-[Tiup]-Download progress shows p/s #451

sre-bot opened this issue Jun 5, 2020 · 1 comment · Fixed by #1312
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug Categorizes issue as related to a bug.

Comments

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

Bug Hunter issue tidb-challenge-program/bug-hunting-issue#40


Bug Report

1. What did you do?

This is a nit, and probably not a P2, but it looked closest based on the classification system.

The bug #103 looks like it might not have been fixed properly. When I run tiup update --nightly --all, I see:

download https://tiup-mirrors.pingcap.com/pd-nightly-linux-amd64.tar.gz 30.52 MiB / 30.52 MiB 99.97% 6.79 MiB p/s                                           ..

My question is, why is p/s required here?

2. What did you expect to see?

It might be nice to format as follows:

[99.97%] https://tiup-mirrors.pingcap.com/pd-nightly-linux-amd64.tar.gz [30.52 MiB / 30.52 MiB] [6.79 MiB/s]                                           
..

This is useful because the percentage can be seen first (because the length of a URL is variable, it makes it hard on the eye to read anything on the right hand side).

3. What did you see instead?

download https://tiup-mirrors.pingcap.com/pd-nightly-linux-amd64.tar.gz 30.52 MiB / 30.52 MiB 99.97% 6.79 MiB p/s                                           ..

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

I have the latest:

wwar@ivory:~$ tiup update --self
download https://tiup-mirrors.pingcap.com/tiup-linux-amd64.tar.gz?v=1587266734335088527 3.31 MiB / 3.34 MiB 99.08% 4.76 MiB p/s                                                                                                                                 
Update successfully!
@lonng lonng transferred this issue from pingcap/tidb Jun 8, 2020
@lucklove lucklove added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug Categorizes issue as related to a bug. labels Jun 28, 2020
@lucklove lucklove added this to Issue Backlog: Need Triage in SIG TiUP Kanban via automation Jun 28, 2020
@liangyuanpeng
Copy link

I am interested in this and i realy do something.

It look like this:

[100.00%] https://tiup-mirrors.pingcap.com/tiup-v1.0.9-linux-amd64.tar.gz [4.32 MiB / 4.32 MiB]  [12.74 MiB p/s]

I have no idea of change MiB p/s to MiB/s , so i have created issue in [Question] How can i use speed about MiB/s and not p/s .

If i missed something, remind me please!

dveeden added a commit to dveeden/tiup that referenced this issue Apr 15, 2021
This fixes pingcap#451

Instead of `1.23 MiB p/s` it now shows `1.23 MiB/s`.
SIG TiUP Kanban automation moved this from Issue Backlog: Need Triage to Done Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug Categorizes issue as related to a bug.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants