Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify coprocessor goroutines to reduce latency in ad-hoc like queries #53250

Open
you06 opened this issue May 14, 2024 · 0 comments · May be fixed by #53251
Open

simplify coprocessor goroutines to reduce latency in ad-hoc like queries #53250

you06 opened this issue May 14, 2024 · 0 comments · May be fixed by #53251
Labels
type/enhancement

Comments

@you06
Copy link
Contributor

you06 commented May 14, 2024

Enhancement

Now the coprocessor works with 3 types of goroutines.

                  ┌────────┐                  
                  │        │                  
             ┌───►│ worker ├───┐              
             │    │        │   │              
             │    └────────┘   │              
             │                 │              
             │    ┌────────┐   │              
             │    │        │   │              
             ├───►│ worker ├───┤              
             │    │        │   │              
             │    └────────┘   │              
             │                 │              
┌────────┐   │    ┌────────┐   │    ┌────────┐
│        │   │    │        │   │    │        │
│ sender ├───┼───►│ worker ├───┼───►│  Next  │
│        │   │    │        │   │    │        │
└────────┘   │    └────────┘   │    └────────┘
             │                 │              
             │    ┌────────┐   │              
             │    │        │   │              
             ├───►│ worker ├───┤              
             │    │        │   │              
             │    └────────┘   │              
             │                 │              
             │    ┌────────┐   │              
             │    │        │   │              
             └───►│ worker ├───┘              
                  │        │                  
                  └────────┘

When the number of tasks is low, the sender is not required, and it can just be:

┌────────┐                  
│        │                  
│ worker ├───┐              
│        │   │              
└────────┘   │              
             │              
┌────────┐   │              
│        │   │              
│ worker ├───┤              
│        │   │              
└────────┘   │              
             │              
┌────────┐   │    ┌────────┐
│        │   │    │        │
│ worker ├───┼───►│  Next  │
│        │   │    │        │
└────────┘   │    └────────┘
             │              
┌────────┐   │              
│        │   │              
│ worker ├───┤              
│        │   │              
└────────┘   │              
             │              
┌────────┐   │              
│        │   │              
│ worker ├───┘              
│        │                  
└────────┘

This can erase the sender goroutine and the channel between sender and workers.
@you06 you06 linked a pull request May 14, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove sender for coprocessor with small number of tasks you06/tidb
1 participant
@you06