Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version to 1.16 #3988

Closed
tisonkun opened this issue May 21, 2021 · 10 comments
Closed

Upgrade Go version to 1.16 #3988

tisonkun opened this issue May 21, 2021 · 10 comments
Milestone

Comments

@tisonkun
Copy link

Development Task

So far, TiDB Operator development uses Go 1.13 which is end of life for a while. Also for supporting running on Apple M1 silicon, it is required to upgrade to 1.16.

@CadmusJiang and @zhouqiang-cl are in charge for upgrading Go version to 1.16 and most of validation works are done manually. Hopefully we get it done in this month.

This also supports TiDB stacks to upgrade Go version to 1.16 pingcap/tidb#22198

@tisonkun
Copy link
Author

tisonkun commented Jun 2, 2021

@CadmusJiang @purelind any updates?

@purelind
Copy link
Contributor

purelind commented Jun 4, 2021

@tisonkun @csuzhangxc Part of github action workflow already update,rest of ci will take some time to test before upgrade go version in ci

@tisonkun
Copy link
Author

tisonkun commented Jun 8, 2021

@purelind is there a schedule, e.g., before July 1st, that we plan to upgrade all pipeline and can do go.mod changes?

@tisonkun
Copy link
Author

tisonkun commented Jul 2, 2021

@purelind any updates?

@csuzhangxc
Copy link
Member

we are pausing this now.

@DanielZhangQD DanielZhangQD added this to the v1.3.0 milestone Jul 16, 2021
@feitian124
Copy link

we are pausing this now.

may i ask why? BTW, hello from csu

@csuzhangxc
Copy link
Member

we are pausing this now.

may i ask why? BTW, hello from csu

just because we don't have time to do this work at the moment, and any contributions are welcome.

@tisonkun
Copy link
Author

tisonkun commented Oct 8, 2021

@csuzhangxc can you elaborate a bit on "any contributions"? It's hard to guess which contributions you looking for for update go version to 1.16. Update the config? Modify CI pipelines? Or other blockers.

@csuzhangxc
Copy link
Member

@csuzhangxc can you elaborate a bit on "any contributions"? It's hard to guess which contributions you looking for for update go version to 1.16. Update the config? Modify CI pipelines? Or other blockers.

we need to upgrade CI both for UT and E2E, and may have some problems for E2E (not tested yet)

@DanielZhangQD
Copy link
Contributor

Trace the go version upgrade in #4474.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants