Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Make Tests compatible to guzzlehttp/psr7:1.6.0 #4595

Closed
fashxp opened this issue Jul 1, 2019 · 2 comments
Closed

[Tests] Make Tests compatible to guzzlehttp/psr7:1.6.0 #4595

fashxp opened this issue Jul 1, 2019 · 2 comments
Assignees
@fashxp
Labels
Bug
Milestone
6.0.1 ("Flanders ...

Comments

@fashxp
Copy link
Member

fashxp commented Jul 1, 2019

error message: Header value must be a string or numeric but boolean provided.

@fashxp fashxp added the Bug label Jul 1, 2019
@fashxp fashxp added this to the 6.0.1 ("Flanders Red Ale") milestone Jul 1, 2019
@fashxp fashxp closed this as completed in aabdac8 Jul 1, 2019
@fashxp fashxp self-assigned this Jul 1, 2019
@fashxp fashxp mentioned this issue Jul 2, 2019
Merged
@solverat
Copy link
Contributor

solverat commented Jul 2, 2019

@fashxp they reverted it in 1.6.1 (symfony/symfony#32292). I don't think it's a good idea to typecast each server value as string since symfony browser accepts the https value as a true boolean type.

@brusch
Copy link
Member

brusch commented Jul 3, 2019

@solverat but they are reapplying it in 2.x so probably it's better to keep the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fashxp fashxp

Labels
Bug
Projects
None yet
Milestone
6.0.1 ("Flanders Red Ale")
Development

No branches or pull requests
3 participants
@brusch @solverat @fashxp