Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix failing float value comparison in codeception tests #13162

Closed
mcop1 opened this issue Sep 15, 2022 · 0 comments · Fixed by #13171
Closed

[Bug]: Fix failing float value comparison in codeception tests #13162

mcop1 opened this issue Sep 15, 2022 · 0 comments · Fixed by #13171
Assignees
Labels
Milestone

Comments

@mcop1
Copy link
Contributor

mcop1 commented Sep 15, 2022

Expected behavior

Float value comparison should return true if the values are the same.

Actual behavior

Doesn´t return true, see failing tests, e.g.
https://github.com/pimcore/pimcore/actions/runs/3057680555/jobs/4933083365
image

Seems to be a problem with floating point precision, float values should be compared with a certain tolerance/delta.

Steps to reproduce

Run GitHub action for codeception test.
Reason for the failing test is sebastianbergmann/comparator#102 , the comparator is used by codeception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant