Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release sameSite = none PR #134

Closed
dustin-H opened this issue Apr 18, 2021 · 3 comments
Closed

Release sameSite = none PR #134

dustin-H opened this issue Apr 18, 2021 · 3 comments
Labels
invalid

Comments

@dustin-H
Copy link

Hi there,

about two years agov0.8.0 was released which should include the sameSite option value none:

See:
#111
fac05de

However, looking at the latest version in npm this feature is missing:
https://www.npmjs.com/package/cookies/v/0.8.0

Could anyone please release the latest master to npm?
@panva
Copy link
Contributor

panva commented Apr 18, 2021

The feature is not missing. It is only lacking docs in the released README.

@dustin-H
Copy link
Author

You're right. I had the wrong version in my project and thought it's the latest, as the docs on npm are the also not mentioning sameSite=none.

Sorry for my false assumption.

A release would nevertheless be useful as the docs are also already fixed:
d211162

@dougwilson
Copy link
Contributor

Closed as already released. We do not make doc only releases. One day if nom let us update does without a release that would be swell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dougwilson @panva @dustin-H