Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not cancelling consumers on channel closure #1208

Open
kjnilsson opened this issue May 1, 2019 · 0 comments
Open

Consider not cancelling consumers on channel closure #1208

kjnilsson opened this issue May 1, 2019 · 0 comments
Assignees
Milestone

Comments

@kjnilsson
Copy link

There is no value in first cancelling all consumers then immediately closing the channel as the consumers will be correctly cleaned up when the channel is closed by RabbitMQ. Consider removing the code around this line: https://github.com/pika/pika/blob/master/pika/channel.py#L544

In RabbitMQ 3.8 we will ship a feature that may require that basic.cancel is not sent before closing the channel for certain guarantees to hold.

@lukebakken lukebakken added this to the 1.0.2 milestone May 1, 2019
@lukebakken lukebakken self-assigned this May 1, 2019
@lukebakken lukebakken modified the milestones: 1.1.0, 2.0.0 Jul 16, 2019
@lukebakken lukebakken modified the milestones: 1.3.0, 2.0.0 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants