Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSVP] What is the source of xxh32zero.go? #194

Closed
sten0 opened this issue Sep 13, 2022 · 2 comments
Closed

[RSVP] What is the source of xxh32zero.go? #194

sten0 opened this issue Sep 13, 2022 · 2 comments

Comments

@sten0
Copy link

sten0 commented Sep 13, 2022

Hi @pierrec,

What is the source of xxh32zero.go? I'm guessing your ported the reference implementation, and that the unreachable url in xxh32zero.go is a form of attribution. Or is this someone else's work that you then built off of?

I was able to circumvent the other issues by excluding files mentioned in #178 and disabling associated tests. Debian ftpmasters are treating #194, this issue, as a hard blocker. Finally this issue is also blocking work on reverse dependencies, so please reply asap :)

Thank you,
Nicholas

@pierrec
Copy link
Owner

pierrec commented Sep 14, 2022

Hi @sten0, sorry for not addressing the other issues, I maintain this lib on my freetime, and it has been very scarce!
I have updated the header of that file so it is now clearer on how this got built (you guessed right).
Let me know if this is OK.

@sten0
Copy link
Author

sten0 commented Sep 14, 2022 via email

@pierrec pierrec closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants