Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not auto-Close() Writer after ReadFrom()/Copy() #184

Merged
merged 1 commit into from May 23, 2022
Merged

do not auto-Close() Writer after ReadFrom()/Copy() #184

merged 1 commit into from May 23, 2022

Conversation

lizthegrey
Copy link
Contributor

ReadFrom()/Copy() should leave it to user whether or not to Close() afterwards rather than shutting down/flushing immediately after the buffer is copied in.

fixes #183

ReadFrom()/Copy() should leave it to user whether or not to Close() afterwards rather than shutting down/flushing immediately after the buffer is copied in.

fixes #183
@lizthegrey
Copy link
Contributor Author

Tests failing because main branch which I forked is failing

@pierrec pierrec merged commit 885e900 into pierrec:v4 May 23, 2022
@lizthegrey lizthegrey deleted the patch-1 branch August 4, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoder.ReadFrom() (added in v4) is buggy
2 participants