internal/lz4block: Simplify portable decoder #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatroar
force-pushed
the
simplify-decode-other
branch
2 times, most recently
from
1f5868d
to
c89b4a4
Compare
|
Closing for now. The test I added shows an inconsistency between the Go and asm implementations. |
greatroar
force-pushed
the
simplify-decode-other
branch
from
c89b4a4
to
ff5f1b0
Compare
|
The inconsistency is #160; it's harmless, just unfortunate. Added an additional test that passes with all four decoders. |
greatroar
force-pushed
the
simplify-decode-other
branch
from
ff5f1b0
to
ce76f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom copy code isn't needed. After copying from the dictionary, we can adjust di and mLen and continue to copy from dst as usual. Also, we only need one case to copy from the dictionary, since copy stops at the end of its shortest input.