Email with null value not working properly

[sumitsharansatsangi]

My table is as follows:

class Student(Table, tablename="student"):
    phone = Varchar(
        length=128,
        primary_key=False,
        index=True,
        index_method=IndexMethod.btree,
        secret=False,
    )
    first_name = Varchar(
        length=100,
        default="",
        null=True,
    )
    last_name = Varchar(
        length=100,
        default="",
        null=True,
    )
    username = Varchar(
        length=15,
        default="",
        null=False,
        primary_key=False,
    )
    email = Email(
        length=100,
        null=True,
    )

When I want to view the Student Table, I receive following error

    json = self.pydantic_model_plural(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 3 validation errors for StudentPlural
rows -> 0 -> email
  value is not a valid email address (type=value_error.email)
rows -> 1 -> email
  value is not a valid email address (type=value_error.email)
rows -> 2 -> email
  value is not a valid email address (type=value_error.email)

[dantownsend]

Try setting required=False.

email = Email(
    length=100,
    null=True,
    required=False
)

I don't think it's well documented - we need to improve that.

[dantownsend]

I'm away from my laptop but will try testing it later.

[dantownsend]

@sinisaos Do you think you can give it a go?

[sumitsharansatsangi]

I think, you don't need to try, Because, I was wrong.
Earlier my table was follows:

class Student(Table, tablename="student"):
    phone = Varchar(
        length=128,
        primary_key=False,
        index=True,
        index_method=IndexMethod.btree,
        secret=False,
    )
    first_name = Varchar(
        length=100,
        default="",
        null=True,
    )
    last_name = Varchar(
        length=100,
        default="",
        null=True,
    )
    username = Varchar(
        length=15,
        default="",
        null=False,
        primary_key=False,
    )
    email = Email(
        length=100,
        null=True,
       default="",   # This line creates the problem
    )

I changed to following

class Student(Table, tablename="student"):
    phone = Varchar(
        length=128,
        primary_key=False,
        index=True,
        index_method=IndexMethod.btree,
        secret=False,
    )
    first_name = Varchar(
        length=100,
        default="",
        null=True,
    )
    last_name = Varchar(
        length=100,
        default="",
        null=True,
    )
    username = Varchar(
        length=15,
        default="",
        null=False,
        primary_key=False,
    )
    email = Email(
        length=100,
        null=True,
    )

But the error persists.
Then I did message, here.
Later, I find , I have just confused empty with null values.
All has to be null or valid email, but all has empty values.

EmailField is working fine, no issue there.
I was wrong.

[sumitsharansatsangi]

@dantownsend , I want to draw your attention in this issue again.
What Email is doing is that it inherits all the property from Varchar. And what Varchar is doing is that when it sees null value , it substitute it with Empty String , i.e. "" which is not a valid email. And for Email when admin is checking for valid email. it gives error.

I don't know exactly how it can be fixed.
One way to do is admin should check for valid email before assigning the empty string i.e. "". But I think this requires implementation of Email from scratch, not by just inheriting Varchar.

@sinisaos , can you suggest something....?

[sinisaos]

@sumitsharansatsangi Quick fix will be change this line in Piccolo to this:

elif isinstance(column, Email):
    value_type = t.Union[pydantic.EmailStr, t.Literal[""]]

This would allow an empty string to pass validation. But that needs to be checked, but I don't have time right now so I'll have a look tomorrow.

[sumitsharansatsangi]

No @dantownsend , piccolo_admin==0.50.0 doesn't fixed the error. What fixed the error is the following answer given by @sinisaos . Does this answer has any side effect, or may raise any problem in future?

@sumitsharansatsangi Quick fix will be change this line in Piccolo to this:

elif isinstance(column, Email):
    value_type = t.Union[pydantic.EmailStr, t.Literal[""]]

This would allow an empty string to pass validation. But that needs to be checked, but I don't have time right now so I'll have a look tomorrow.

[dantownsend]

Does your column look like this:

Email(null=True, default=None, required=False)

Changing the Pydantic validation works, but isn't the root cause, so would rather not change it.

[sinisaos]

@sumitsharansatsangi I don't know what is causing your problems, but all options work for me

email = Email(null=True)
email = Email(null=True, default="")
email = Email(null=True, default=None)
email = Email(null=True, default=None, required=False)

@dantownsend All options works for me

[dantownsend]

Maybe the files are cached in the browser? I'm not at my laptop currently, so can't check.

[sumitsharansatsangi]

@sinisaos, As @dantownsend said, I think cache was the problem.
It's working now, you don't need to check @dantownsend .
Thanks...