-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not update package cache on install/upgrade #5502
Conversation
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pihole-up-skip-package-update/66512/15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we wan to keep notify_package_updates_available()
?
No, I think this is only due to the artificially clean environment of a CI container. No real OS will know nothing about their sources. We neither support installing into naked container (or do we?). If we do, the logic needs to be changed to use Converting this PR to draft and doing this later... |
0094c47
to
e686f6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a good place to put the update function. It will update the cache 3 times in a row on new installs as install_dependent_packages()
is called 3 times during installation and usually not empty.
Signed-off-by: DL6ER <dl6er@dl6er.de>
e686f6a
to
b5e4a16
Compare
@yubiuser I simplified the approach |
I'm a little confused as to the logic here...
What I can't see here is how we get ourselves into a situation where Maybe I'm just being dense... but what is the goal here? |
I think this PR has been changed too often and it was abandoned too often, too, to reproduce its original intention. Closing. |
What does this implement/fix?
Do not update package cache on install/upgrade. It takes quite a long time and we don't do this for
dnf
/yum
either.Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.