-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate dnsmasq config files #5479
Conversation
…ed directory Signed-off-by: DL6ER <dl6er@dl6er.de>
…after pi-hole/pi-hole#5479 Signed-off-by: DL6ER <dl6er@dl6er.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get some rest!
Co-authored-by: Adam Warner <me@adamwarner.co.uk> Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>
Signed-off-by: DL6ER <DL6ER@users.noreply.github.com>
Sorry, I don't really know what happened here. The file somehow got mangled after I tested it... Thanks for your thorough check! |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
Does this branch need rebasing? Just built a local container based on it and:
|
Indeed, a |
This PR still needs merging to ensure we remove files from |
What does this implement/fix?
Migrate
dnsmasq
config files originally created by a Pi-hole version pre-v6.0 from/etc/dnsmasq.d
into a new directory owned by user/grouppihole
. This ensures they stay available for later debugging, and won't cause when, e.g., the user later decides to install adnsmasq
from the repository.The differences to how it is done before are:
dnsmasq
and won't cause conflicts,root
(pihole-FTL
could then not move/rename them itself).This PR is meant to be used in combination with pi-hole/FTL#1737
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.