You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, TableSlice::print_tty() panics on I/O errors. I think it should return an error instead of panicking, because I/O errors are not exceptional situations. Panics are reserved to exceptional situations.
For example, failing to write to the standard output due to a broken pipe (EPIPE) is very common when commands are piped to head, tail, more, etc. The current behavior causes applications using this crate to panic when that happens, instead of simply exiting. See issue 16 in bingrep.
The text was updated successfully, but these errors were encountered:
Currently,
TableSlice::print_tty()
panics on I/O errors. I think it should return an error instead of panicking, because I/O errors are not exceptional situations. Panics are reserved to exceptional situations.For example, failing to write to the standard output due to a broken pipe (EPIPE) is very common when commands are piped to
head
,tail
,more
, etc. The current behavior causes applications using this crate to panic when that happens, instead of simply exiting. See issue 16 in bingrep.The text was updated successfully, but these errors were encountered: