Store baseline and neon configs as php code

[thbley]

Feature request

I'm requesting to store the baseline file in php code instead of neon format.
Using php code, we could also use opcache in cli with file_cache_only.
Our baseline is 167k loc with 8M in size.
When analyzing an empty php file, it takes 11s with the baseline.neon and 2s without the baseline.neon, so parsing the baseline takes about 8s on an amd 5825U.

Same for the rules.neon files. We use a couple of neon files in the "includes". When I include all configs, parsing an empty php file takes 11s, when I disable all in the include section, it takes 2s.

Did PHPStan help you today? Did it make you happy in any way?

Yes, PHPStan is helping us every day, great tool!

[ondrejmirtes]

Sorry, I don't think we can do anything to improve working with such a huge baseline. The documentation (https://phpstan.org/user-guide/baseline) states:

It works best when you want to get rid of a few dozen to a few hundred reported errors that you don’t have time or energy to deal with right now. It’s not the best tool when you have 15,000 errors — you should probably spend more time configuring PHPStan or run it with a lower rule level.

I recommend you to trim down the baseline.

Even if you keep such a big baseline, taking 11s isn't that bad.

[thbley]

This is the output from xdebug using kcachegrind:

When analyzing an empty php file and it takes >20s, I guess there is room for improvement.

[ondrejmirtes]

Good news:

• phpstan/phpstan-src@8260032
• b2325f6

[thbley]

Thanks!

[gnutix]

@ondrejmirtes Thanks for this new feature! I've just tried it out, and the performance improvement is great. 🎉

I do have some smalls suggestions for improvements regarding the "code style" of the generated file :

1. Replace tabs by spaces before the 3 keys (message, count, path), so that there's only spaces in the file
2. Trim the 3 spaces before each $ignoreErrors[] = [ (probably caused by the HereDoc syntax)
3. Add a new line at the end of file (to prevent warnings / automatic fixing on git and some IDEs)

[herndlm]

@gnutix you might want to follow phpstan/phpstan-src#2266 :)

[ruudk]

1. Replace tabs by spaces before the 3 keys (message, count, path), so that there's only spaces in the file

Fixed in phpstan/phpstan-src#2269

2. Trim the 3 spaces before each $ignoreErrors[] = [ (probably caused by the HereDoc syntax)

Fixed in phpstan/phpstan-src@144da80 (pending release)

3. Add a new line at the end of file (to prevent warnings / automatic fixing on git and some IDEs)

Fixed in phpstan/phpstan-src@c9b5060 (pending release)

[gnutix]

Thanks @ruudk for your work! I like the "one line per error" idea too. Will make things was more compact, and even git stats (line removed) will match errors count somewhat. :)

[ruudk]

@gnutix Please respond in that PR, seems it's not going to be merged 😊

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.