Performance problem - big arrays

[ondrejmirtes]

Feature request

This file https://github.com/mmarton/phpstan-issue8146/blob/master/src/DataFixtures/LocationFixtures.php from #8146 really slows PHPStan down, because it contains a lot of literal arrays.

The performance was better before: phpstan/phpstan-src#1741

This PR phpstan/phpstan-src#1830 looked promising, it improved the performance on 1.8.x, but after rebasing on 1.9.x, it's slow again.

This PR phpstan/phpstan-src#2077 (basically a revert of phpstan/phpstan-src#1741) helps to solve this problem by dumbing down huge constant arrays (making types less precise) at the cost of new false positives because of the lost precision.

[ondrejmirtes]

Another example is https://github.com/phpstan/phpstan-src/blob/98c66f30dea8bbb075e327cb5c415427000446e8/tests/PHPStan/Analyser/data/bug-8146a.php

[ondrejmirtes]

The current result is that on 1.9.2, the sample project takes 2m34s to analyse, with 1.9.x-dev, it takes 47s! /cc @staabm

[staabm]

ahhh I love it. still too slow, but way better then before :)

[ondrejmirtes]

Should be better now after phpstan/phpstan-src#2116 and phpstan/phpstan-src#2077 :)

Still need to investigate why #8004 fails on return.

[bcremer]

Can confirm a reduction from 8 to 6 minutes for a bigger Laminas MVC application 🥳

[SaschaHowe]

Hey,

just checked on this again. My Test case (this one: #8504 (comment)) went down for me this morning from 83.43s under 1.8.7 to 0.23s with 1.9.11. This is basically as good as it was prior to 1.8.7.

Great work and thank you so much 👍

Greetings,
Sascha

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.