ConditionalExpressionTypes todos

[rajyan]

Feature request

Make ConditionalExpressionTypes to work for all expressions

• Use ExpressionTypeHolders for conditions
• Change addConditionalExpressions first arg to expr from exprString and delete exprStringToExpr Improve conditionalExpressionTypes phpstan-src#1950 (comment)
• Solve the infinite loop problem mentioned in Improve conditionalExpressionTypes phpstan-src#1950 (comment) when filterBySpecifiedTypes is used for BinaryOp's that uses filterByTruthy/FalsyTypes
• fix bug of processBooleanConditionalTypes mentioned in Improve conditionalExpressionTypes phpstan-src#1950 (comment)
• Make processBooleanConditionalTypes work for all expressions
• Make createConditionalExpressions work for all expressions
• Make processSure/SureNotTypesForConditionalExpressionsAfterAssign work for all expressions

Add conditional types for these types of dependent types

• Dependent variables not working if dependency referenced in another condition #5401 (comment)
  • https://phpstan.org/r/ce00cd7d-d22e-455a-b646-a48261f71091
  • https://phpstan.org/r/aab74e73-2bfe-432b-8bcd-f9b939d2eaab
• commented out test in https://github.com/phpstan/phpstan-src/blob/1.9.x/tests/PHPStan/Analyser/data/dependent-variable-certainty.php

Replace conditionalExpressionTypes with a LateResolvableType

• Create a LateResolvableType to handle conditionalExpressionTypes
• Replace conditionalExpressionTypes usage in MutatingScope
• Replace conditionalExpressionTypes usage in NodeScopeResolver
• Replace conditionalExpressionTypes usage in TypeSpecifier

[staabm]

Not sure its goal of this issue, but this should also work:

https://phpstan.org/r/fada5ae5-5144-4a85-8c93-f0079fe49b4c

[rajyan]

Thank you for the example. This should work after

Make processBooleanConditionalTypes work for all expressions

is done:+1:

[rajyan]

https://phpstan.org/r/8dba4abf-3e1c-499b-9c43-92495d677850

some examples of non working assertainty

[rajyan]

Brain stormed a lot about conditional types, I think merging them as LateResolvableType might not be possible.
Maybe there is a hint in muglug's comment
#3677

[rajyan]

Merging conditional types can be improved than simple intersection.
we can delete resolved conditions here
https://github.com/phpstan/phpstan-src/pull/2030/files#diff-dc817f2bab8672057a95375a542e68599164f6ab2380e4cccd1b50583e295d85R3737-R3752
if the conditional type is same as the other variable type we don't have to delete the conditional types.

https://github.com/phpstan/phpstan-src/blob/615dcd274a8d4b6e8da9a01a1b69df19a2dbbbb6/tests/PHPStan/Analyser/data/bug-8361.php#L1-L32

This test should be helpful when making that improvemnet

[rajyan]

Another improvement I can think of

https://github.com/phpstan/phpstan-src/pull/2056/files#diff-1df21d1d92824f6e7a9f5a77cb3af7c598a540f19507d1d9851fe4c4f4cfbb58R32

we can resolve conditional type here for union types

[rajyan]

Another example
phpstan/phpstan-src@34b64bb

https://phpstan.org/r/bdf6da49-f84e-4a41-917b-f9639f64b742

[rajyan]

phpstan/phpstan-src#2061 (comment)

[rajyan]

#8543 (comment)

The conditional type seems created before the assign? and invalidated?