array_shift, null coalescing operator and throw

[verfriemelt-dot-org]

Bug report

playground: https://phpstan.org/r/3a7ec8b3-fd08-4eee-b3a7-2f2098b6ec15

array_shift($args) ?? throw new \RuntimeException('missing center lat');

yields: Expression on left side of ?? is not nullable.

Expected output

since array_shift can and will return null, i'd expect this to be valid. and raise no errors

Did PHPStan help you today? Did it make you happy in any way?

as happy as ever, this is such a help on a day to day basis! :)

[herndlm]

interesting, ArrayShiftFunctionReturnTypeExtension should handle this case I think, but apparently there is no null return type added https://phpstan.org/r/a5f5f209-3b16-498b-bd6f-889215861532

[herndlm]

ah I'm an idiot, of course it is added, but mixed|null is mixed xD so the problem is most likely then that mixed ?? throw in that context does not work correctly :)

[rvanvelzen]

array_shift should probably be marked as having side effects. Perhaps all functions with by-ref parameters should be marked as such?

[mad-briller]

i tried manually adding 'array_shift' => ['hasSideEffects' => true] to functionMetadata and separately adding a stub to arrayFunctions that had @phpstan-impure on it, but neither of those things rectified the issue,
am i missing the correct way to mark something as impure?

[staabm]

Did you follow the steps in the file comment of https://github.com/phpstan/phpstan-src/blob/1.9.x/resources/functionMetadata.php ?

[mad-briller]

not gonna lie, i missed that comment entirely, thanks @staabm

however manually updating the file should be a quick estimate of the outcome of those steps right? so there has to be another issue at play here

[ondrejmirtes]

Duplicate of #8084

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.