more precise Superglobals / readonlySuperglobals

[staabm]

Feature request

in psalm with vimeo/psalm#8473 recently more precise Superglobals were added.
I am thinking about doing the same for phpstan behind a readonlySuperglobals feature flag.

in tandem I would implement a new Rule which errors when code modifies one of the superglobal arrays.
(so we can "prevent" people writing types into a superglobal which don't fit the intended types)

https://phpstan.org/r/e99e22a3-014d-4edf-85ed-969857a34af5

wdyt?

[mvorisek]

Yes, for example $_GET can be only string or array of strings.

[phpstan-bot]

@staabm After the latest push in 1.11.x, PHPStan now reports different result with your code snippet:

@@ @@
- 7: Dumped type: array<string, mixed>
- 8: Dumped type: array<string, mixed>
- 9: Dumped type: array<string, mixed>
-10: Dumped type: array<string, mixed>
-11: Dumped type: array<string, mixed>
-12: Dumped type: array<string, mixed>
-13: Dumped type: array<string, mixed>
-14: Dumped type: array<string, mixed>
+ 7: Dumped type: array
+ 8: Dumped type: array
+ 9: Dumped type: array
+10: Dumped type: array
+11: Dumped type: array
+12: Dumped type: array
+13: Dumped type: array
+14: Dumped type: array

Full report

Line	Error
7	Dumped type: array
8	Dumped type: array
9	Dumped type: array
10	Dumped type: array
11	Dumped type: array
12	Dumped type: array
13	Dumped type: array
14	Dumped type: array