Make @psalm-readonly-allow-private-mutation as alias of readonly

[zonuexe]

Feature request

In Psalm, @psalm-readonly-allow-private-mutation is shorthand for combining @readonly and @psalm-allow-private-mutation. Adding @psalm-readonly-allow-private-mutation to PHPStan as an alias for @readonly improves interoperability.

I liked Psalm's @psalm-allow-private-mutation so I looked into PHPStan's implementation to bring the same functionality into PHPStan, but found that ReadOnlyByPhpDocPropertyAssignRule implicitly behaves as a private mutation. So we don't need to add @phpstan-allow-private-mutation.

Did PHPStan help you today? Did it make you happy in any way?

I've been working on a major refactoring for the last few days and I'm really grateful for PHPStan.

[zonuexe]

@phpstan-disallow-private-mutation is required for Psalm compatibility, but I don't have that use case 😄. https://phpstan.org/r/9002912b-4c80-43bb-8184-4ab6d1437b83

[zonuexe]

@ondrejmirtes
I missed that readOnlyByPhpDoc is enabled by bleedingEdge. Are you sure you want to add @phpstan-allow-private-mutation and @phpstan-readonly-allow-private-mutation like Psalm?

[ondrejmirtes]

I don't want these extra features now, I just want to be cross-compatible with Psalm. Just test the code you added 😊

[zonuexe]

Ok, I'll make a proposal in another issue to add the feature.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.