Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slowness since an upgrade #7598

Closed
epeliberty opened this issue Jul 8, 2022 · 5 comments
Closed

Slowness since an upgrade #7598

epeliberty opened this issue Jul 8, 2022 · 5 comments

Comments

@epeliberty
Copy link

epeliberty commented Jul 8, 2022

Bug report

Since we updated the version of PHPStan from 0.12.84 to 1.7.15, we have significant slowness in CI testing via Github Actions.

For the same file volumes we went from an average of 1min20 to more than 6min.

Code snippet that reproduces the problem

Before in our composer.json

"require-dev": {
        ...
        "phpstan/phpstan": "^0.12.19",
        "phpstan/phpstan-doctrine": "^0.12.10",
        "phpstan/phpstan-phpunit": "^0.12.8",
        "phpstan/phpstan-symfony": "^0.12.6",
        ...
}

After

"require-dev": {
        ...
        "phpstan/phpstan": "^1.7",
        "phpstan/phpstan-doctrine": "^1.3",
        "phpstan/phpstan-phpunit": "^1.1",
        "phpstan/phpstan-symfony": "^1.2",
        ...
}

In our Github Actions :

      - name: Run PHP STAN on whole project
        run: vendor/phpstan/phpstan/phpstan analyse --configuration=phpstan.ci.neon --error-format=prettyJson

Currently, it is difficult for us to have this slowdown of several extra minutes for each validation of pull requests :(

Do you have an idea of the origin of these slowdowns since the PHPStan upgrade?

We are still in PHP 7.4 for a Symfony 3.4 project

Thanks in advance

Not https://phpstan.org/try/... because it's during CI Validation

@mergeable
Copy link

mergeable bot commented Jul 8, 2022

This bug report is missing a link to reproduction at phpstan.org/try.

It will most likely be closed after manual review.

@herndlm
Copy link
Contributor

herndlm commented Jul 8, 2022

I suggest to follow the advise from #7581 (comment)
If you're lucky, people can optimise phpstan based on the profiles.

@epeliberty
Copy link
Author

thanks @herndlm

@ondrejmirtes
Copy link
Member

There was no follow up information to act on. I suggest you try PHPStan 1.8.3 once it's released, and report back if the problem persists. Thanks.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants