Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return $this is not returning $this when $this is compared with static before #7550

Closed
mvorisek opened this issue Jun 29, 2022 · 3 comments
Closed

return $this is not returning $this when $this is compared with static before #7550

mvorisek opened this issue Jun 29, 2022 · 3 comments
Labels
bug
Milestone
Easy fixes

Comments

@mvorisek
Copy link
Contributor

Bug report

demo: https://phpstan.org/r/560bf50c-a0cf-41b7-a182-e4a22cb195d3

broken since the new release 1.8.0
@mvorisek mvorisek changed the title return $this is not returning $this when ˙$this˙ is compared with static before return $this is not returning $this when this is compared with static before Jun 29, 2022
@mvorisek mvorisek changed the title return $this is not returning $this when this is compared with static before return $this is not returning $this when $this is compared with static before Jun 29, 2022
@ondrejmirtes ondrejmirtes added this to the Easy fixes milestone Jun 29, 2022
@ondrejmirtes
Copy link
Member

This gets lost because of this optimization: phpstan/phpstan-src#1471

@mvorisek mvorisek mentioned this issue Jun 30, 2022
Merged
@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@e20e934

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Easy fixes
Development

No branches or pull requests
2 participants
@ondrejmirtes @mvorisek