Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test phpstan /w restricted php.ini conf #7488

Closed
wants to merge 1 commit into from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jun 18, 2022

test #4147 and also disabled proc_open (which imply no parallelization possible)

probably no need to run full phpstan with these configurations

@mvorisek mvorisek marked this pull request as ready for review June 18, 2022 12:01
@mvorisek
Copy link
Contributor Author

@ondrejmirtes test should be working, but for some reasons, the original code is run

@ondrejmirtes
Copy link
Member

You get a nice error message:

In Process.php line 118:

  The Process class relies on proc_open(), which is not available on your PHP
   installation.

This behaviour is expected. There's no reason to disable these functions in the environment where you want to run PHPStan.

@mvorisek
Copy link
Contributor Author

mvorisek commented Jun 20, 2022

No, it the "detect CPU cores" code already account for that and it was working. But it was broken with some recent release.

In some environments, exec (and friends) functions can be disabled and phpstan should continue to work (using 1 process only).

@mvorisek
Copy link
Contributor Author

@ondrejmirtes please reopen this PR, I will try to fix the issue, it worked before and phpstan should continue to work /w that php.ini configuration

@ondrejmirtes
Copy link
Member

You can send a PR with a fix to phpstan-src and link this closed PR once you think it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants