Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stubs loaded with StubFilesExtension are not validated #7330

Closed
canvural opened this issue May 27, 2022 · 4 comments
Closed

Stubs loaded with StubFilesExtension are not validated #7330

canvural opened this issue May 27, 2022 · 4 comments

Comments

@canvural
Copy link
Contributor

Feature request

Stubs loaded with StubFilesExtension are not validated. Is this done on purpose? My use case is that we have a lot of stub files, and adding each one of them to extension.neon file is cumbersome. So my idea was to write an extension that loads all *.stub files in stubs directory.
@ondrejmirtes
Copy link
Member

ondrejmirtes commented May 27, 2022 •
edited

Yeah, this is criminally inconsistent for no reason :) I fixed it: phpstan/phpstan-src@d3589dc

What's nice that it enables to do things like #4342 really easily.

@canvural
Copy link
Contributor Author

Oh, awesome! Thank you!

@canvural
Copy link
Contributor Author

I was testing 1.7.x-dev but it doesn't seem to work still. Shouldn't something here be changed also?

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ondrejmirtes @canvural