Assign readonly property value using list is not handled

[niconoe-]

Bug report

When using the list syntax or its short version to assign values to readonly properties in a constructor, the assignation is not taken into account, and this creates a false positive.

Code snippet that reproduces the problem

Here is an example of snippet that throws an error

Expected output

No error.

Did PHPStan help you today? Did it make you happy in any way?

PHPStan is helping me everyday and I'll never thanks enough people who are making this better and better everyday! A huge THANK YOU!

[ondrejmirtes]

FYI @herndlm This one is worth investigating. The thing that we should take advantage of is that array destructuring is correctly handled in TypesAssignedToPropertiesRule so the readonly check should take advantage of PropertyAssignNode (ClassStatementsGatherer uses it to create PropertyWrite so I don't really know what's wrong). The array destructuring probably creates PropertyRead too which isn't desired.

[herndlm]

Yeah, sounds like you're guess is correct. ClassStatementsGatherer basically finds the PropertyFetch but does not exit early in https://github.com/phpstan/phpstan-src/blob/1.7.11/src/Node/ClassStatementsGatherer.php#L186 since Scope::isInExpressionAssign returns false and then it creates the PropertyRead.

I'm not entirely sure yet how to fix this, let me know if you have an idea already. Currently I'm looking into passing around enterExpressionAssign and calling Scope::enterExpressionAssign in NodeScopeResolver since doing this for the outer expression is not enough. I have the feeling that there is a better way to "remember" that we're currently in an assignment expression, but not sure yet.

[ondrejmirtes]

Yes, that's probably the right way :)

[niconoe-]

Thank you very much for taking care of this! You rock!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.