Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$b = [] == []; makes phpstan crash #6940

Closed
icatalina opened this issue Mar 30, 2022 · 7 comments
Closed

$b = [] == []; makes phpstan crash #6940

icatalina opened this issue Mar 30, 2022 · 7 comments

Comments

@icatalina
Copy link

Bug report

$b = [] == [];

makes phpstan crash and report nothing.

Code snippet that reproduces the problem

https://phpstan.org/r/8242afb1-8620-4be1-887d-0863ef990dfd

Expected output

A valid report from the file.

@herndlm
Copy link
Contributor

herndlm commented Mar 30, 2022

I'll push a fix in a minute

@herndlm
Copy link
Contributor

herndlm commented Mar 30, 2022

@phpstan-bot looks like you can't find that this has been fixed? 🤔

@ondrejmirtes
Copy link
Member

It looks only for open issues tagged with Bug / Feature request.

Also looks like GitHub ignores "closes" references in merged PRs now.

@staabm
Copy link
Contributor

staabm commented Mar 30, 2022

Also looks like GitHub ignores "closes" references in merged PRs now.

yeah, I had the same impression.

I guess they disabled some features, since they had a lot of trouble over the last view weeks to get a stable user experience across github.com

@ondrejmirtes
Copy link
Member

I'll go and close them when I complete the release notes.

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src#1143

@github-actions
Copy link

github-actions bot commented May 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants