Incorrect signature for the set_error_handler() callback in PHP >= 8

[johnbillion]

Bug report

Since PHP 8 the $errcontext parameter is no longer passed to the callback registered with set_error_handler(). This is not detected by PHPStan.

Code snippet that reproduces the problem

• https://phpstan.org/r/17a4dab8-c0d1-4f1c-af1b-869420718490
• https://3v4l.org/MiqGP
• https://www.php.net/manual/en/function.set-error-handler.php

Expected output

The $errcontext parameter of the callback signature should be conditional depending on the PHP version.

Did PHPStan help you today? Did it make you happy in any way?

Always :-)

[ondrejmirtes]

This is the actually crashing code that should be reported by PHPStan on PHP 8.0+: https://3v4l.org/pp25P

Looks like set_error_handler doesn't have an item in https://github.com/phpstan/phpstan-src/blob/master/resources/functionMap.php. Please add it to this file with a signature relevant for 7.4.

And then add a line in https://github.com/phpstan/phpstan-src/blob/master/resources/functionMap_php80delta.php with a signature relevant for 8.0+.

Thanks.

[johnbillion]

There is an entry, I think there's something up with GitHub's rendering of large files. I'm working on a PR at the moment.

[ondrejmirtes]

Awesome 👍

[ondrejmirtes]

The playground now gives expected results :)

• https://phpstan.org/r/98ee791a-e304-4c2f-b346-3c476424f430
• https://phpstan.org/r/e41ab957-e2b7-4cf7-bfa2-52c8b2b04f9a

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.