Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize directory separators in all outputted paths #6483

Closed
paranoiq opened this issue Jan 29, 2022 · 3 comments
Closed

Normalize directory separators in all outputted paths #6483

paranoiq opened this issue Jan 29, 2022 · 3 comments

Comments

@paranoiq
Copy link
Sponsor Contributor

paranoiq commented Jan 29, 2022

Feature request

many modern shells and terminals allow opening URLs and file paths by Ctrl+clicking. this feature is however crippled by combination of paths with backslashes and some not-so-native tools (like Git Bash) removing them:

image

image

the simple solution is to always normalize all outputted paths to forward slashes. everybody should do that. lets forget that backslashed paths ever existed!

Did PHPStan help you today? Did it make you happy in any way?

PHPStan is great! 🤓


also: git-for-windows/git#3665

@ondrejmirtes
Copy link
Member

Try this: phpstan/phpstan-src#1013

I'll reopen if it doesn't work for you.

@staabm
Copy link
Contributor

staabm commented Feb 14, 2022

my testing suggests the initial reported problem is still happening on latest phpstan@master.

it seems the output in the git bash got even uglier, as the "html like" href are rendered

phpstan-master:

grafik

phpstan 1.4.6

grafik

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants