\DomDocument::save() is considered not returning false

[kissifrot]

Bug report

Hello,
It looks like \DomDocument::save() isn't expected to return false by phpstan

Code snippet that reproduces the problem

Snippet

I'm getting an error Method HelloWorld::storePayload() never returns false so it can be removed from the return type.

Expected output

Method signature is public DOMDocument::save(string $filename, int $options = 0): int|false , so indeed it can return false 😉

Did PHPStan help you today? Did it make you happy in any way?

Sure! :)

[staabm]

Needs fixing in the signature file https://github.com/phpstan/phpstan-src/blob/daf7d5577bd8c796509768eb6a8d2862b6027a53/resources/functionMap.php#L1924

Could you send a PR?

[kissifrot]

Sure: phpstan/phpstan-src#956

[ondrejmirtes]

Fixed by phpstan/phpstan-src#956

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.