Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right side of || is always false. when using earlyTerminatingFunctionCalls #6258

Closed
sascha-egerer opened this issue Dec 30, 2021 · 2 comments

Comments

@sascha-egerer
Copy link
Contributor

Bug report

In TYPO3 some files have some security guard to prevent that they are accessed from the public via the web server.
It looks like this:

defined('TYPO3_MODE') or die();

But this does end up in Right side of || is always false. but should not as the "right side" is terminating the process.

Code snippet that reproduces the problem

https://phpstan.org/r/d14b33ad-a59f-46ef-b061-6ada8b613794

Expected output

There should be no issue if the right part of a or is an earlyTerminatingFunctionCall

@ondrejmirtes
Copy link
Member

Fixed: phpstan/phpstan-src@fe3a341

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants