array_key_exists false positive

[Mika-]

Bug report

array_key_exists result seems to get cached when calling multiple times and treatPhpDocTypesAsCertain is false.

Code snippet that reproduces the problem

https://phpstan.org/r/b188b057-febf-4611-8d1b-2dec775d1892

Expected output

No errors

[herndlm]

Hi, I had a quick look and saw that the constants are the "problem". BUT I think it's working as expected, as you're relying on static which is unsafe. Try either making the class final or use self:: to access the constants. See https://phpstan.org/r/52898302-552d-4fa9-b45b-ade25cb8c7e6

[Mika-]

That seems to be the case. Static constant reference being resolved as mixed and then being evaluated twice the same way results as false positive.
Maybe this kind of cases should be silently ignored as happens when treatPhpDocTypesAsCertain is enabled.

[herndlm]

@Mika- the remaining error is coming from StrictComparisonOfDifferentTypesRule which is enabled with level 4 => it would be off on 3. But I guess it's not in your interest to go down to 3 :)

Anyways, do you agree that this is not a bug then? I think it behaves as expected.

[ondrejmirtes]

You should use self::KEY_VERSION etc. but this is still a bug.

[herndlm]

Aah I think I got it, was thinking too much about types only. The constants are different of course and should not influence each other..

[phpstan-bot]

@Mika- After the latest push in 1.8.x, PHPStan now reports different result with your code snippet:

@@ @@
-17: Strict comparison using === between false and true will always evaluate to false.
+No errors

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.