PHPStan does not detect that shuffle() reindexes array keys

[johnbillion]

Bug report

When an array is passed to shuffle() it gets reindexed from 0. PHPStan does not detect this.

Code snippet that reproduces the problem

• https://3v4l.org/n9HIf
• https://phpstan.org/r/ee6853b0-c54a-48c0-97aa-579ee507d9b9

Expected output

shuffle() should be aware that the array that's passed to it gets reindexed from 0.

Did PHPStan help you today? Did it make you happy in any way?

Always :)

[staabm]

Feel free to implement a Dynamic Return Type extension for shuffle

https://phpstan.org/developing-extensions/dynamic-return-type-extensions

[ondrejmirtes]

AFAIK shuffle() doesn't return the shuffled array, but changes it in-place. The extension isn't applicable here, instead it needs to be hardcoded in NodeScopeResolver.

[johnbillion]

Correct, it's one of the array functions that operates directly on the array passed by reference.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.