Arrays considered as callables break autoloading

[Wirone]

Bug report

Since 1.2.0 we have problems with discovering symbols that were correct on 1.1.2 - it looks like it's related to MemoizingReflectionProvider::hasClass() and most probably PHPStan\Dependency\DependencyResolver::considerArrayForCallableTest().

Code snippet that reproduces the problem

ℹ️ Reproducer repo

<?php

declare(strict_types=1);

# Comment it and error disappears
$array = ['y'];

class X
{
    public function __construct()
    {
        (new \Y())->get();
    }
}

Somehow ['y'] is considered as callable and autoloading system tries to load class y. Result is cached within MemoizingReflectionProvider so when new \Y() is executed it won't work because PHPStan thinks class does not exist (provider uses lowercased names).

Additional info:

• custom autoloader must(?) be used, we couldn't reproduce it with Composer's one
• order of analysis is important, because if ['y'] is used after new \Y() it does not report error (in the example it's within one file, but in our repo it's in different files)

Expected output

No error like in 1.1.*

Did PHPStan help you today? Did it make you happy in any way?

I really like that @ondrejmirtes is available at Slack and I can ask him directly about our problems 🙂

[mergeable]

This bug report is missing a link to reproduction on phpstan.org.

It will most likely be closed after manual review.

[ondrejmirtes]

This should be solved by phpstan/phpstan-src@792ce0a and phpstan/phpstan-src@b927c87.

Please try this with two-element arrays as well, thanks.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.